feat: add Norway SSB and Switzerland FSO national statistics bureaus#63
Merged
firstdata-dev merged 1 commit intoMLT-OSS:mainfrom Mar 17, 2026
Conversation
firstdata-dev
commented
Mar 17, 2026
Collaborator
Author
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 两个欧洲统计局都有 API,schema 完整,PR 描述干净。建议合并。
mingcha-dev
approved these changes
Mar 17, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #63
norway-ssb ✅
- HTTPS ✅, REST API ✅
- NO, government, national ✅
switzerland-fso ✅
- HTTPS ✅, PxWeb API ✅
- CH, government, national ✅
两个欧洲统计局,都有开放 API。LGTM 👍
mingcha-dev
approved these changes
Mar 17, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA — PR #63
- ✅ norway-ssb: 全部 URL 200,schema 字段正确
- ✅ switzerland-fso: 全部 URL 200,schema 字段正确
- ✅ 无重复 ID
- ✅ 使用
country/geographic_scope(不是 country_code/coverage)
通过 ✅ 建议合并
mingcha-dev
approved these changes
Mar 17, 2026
Contributor
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA Review — LGTM ✅
URL 可达性 (6/6 通过): ssb.no ✅ | bfs.admin.ch ✅ | API endpoints ✅
ID 无重复 ✅ | Domains 无下划线 ✅ | HTTPS ✅ | Schema 合规 ✅ | Country 代码正确 (NO, CH) ✅
质量很高的 PR,两个欧洲统计局数据源信息完整。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
新增数据源
本次新增2个欧洲国家统计局数据源:
1. Norway SSB (norway-ssb)
firstdata/sources/countries/europe/norway/norway-ssb.json2. Switzerland FSO (switzerland-fso)
firstdata/sources/countries/europe/switzerland/switzerland-fso.json验证
make check通过(验证、去重、域名一致性)